Skip to content

fix: problem with creating lessons without solution files #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

leonyoung1
Copy link
Contributor

fix for #107 In the hasSolution function of TutorialStore, this._lessons.solution is an array with the structure [lessonName, [list of solution files]]. Instead of checking the length of the solution array. we have to check the length of the second index which is the list of solution files.

fix for stackblitz#107
In the hasSolution function of TutorialStore, `this._lessons.solution` is an array with the structure [lessonName, [list of solution files]]. Instead of checking the length of the solution array. we have to check the length of the second index which is the list of solution files.
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@leonyoung1 leonyoung1 changed the title fix: Problem with creating lessons without solution files fix: problem with creating lessons without solution files Jun 30, 2024
Copy link
Member

@Nemikolh Nemikolh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 🤩

And thanks a lot for the fix 🎉

@Nemikolh Nemikolh merged commit 2d51ff7 into stackblitz:main Jun 30, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants