-
Notifications
You must be signed in to change notification settings - Fork 84
chore: update release workflow #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLI's PR commit has same issue:
tutorialkit/.github/workflows/publish-release.yaml
Lines 67 to 75 in 8b8b1ca
- name: Create Pull Request | |
uses: peter-evans/create-pull-request@v6 | |
with: | |
# Note: `publish-release.yaml` checks explicitly for this commit message | |
commit-message: 'chore: release tutorialkit CLI, version: ${{ steps.resolve-release-version.outputs.version }}' | |
title: 'chore: release tutorialkit CLI, version: ${{ steps.resolve-release-version.outputs.version }}' | |
body: 'Bump tutorialkit CLI to version ${{ steps.resolve-release-version.outputs.version }}' | |
reviewers: SamVerschueren,d3lm,Nemikolh,AriPerkkio | |
branch: chore/release-cli-${{ steps.resolve-release-version.outputs.version }} |
Wait, what do you mean has some issues? |
I mean let's apply this same change to CLI's PR comments. It's also missing the dot. - name: Create Pull Request
uses: peter-evans/create-pull-request@v6
with:
# Note: `publish-release.yaml` checks explicitly for this commit message
commit-message: 'chore: release tutorialkit CLI, version: ${{ steps.resolve-release-version.outputs.version }}'
title: 'chore: release tutorialkit CLI, version: ${{ steps.resolve-release-version.outputs.version }}'
- body: 'Bump tutorialkit CLI to version ${{ steps.resolve-release-version.outputs.version }}'
+ body: 'Bump tutorialkit CLI to version ${{ steps.resolve-release-version.outputs.version }}.'
reviewers: SamVerschueren,d3lm,Nemikolh,AriPerkkio
branch: chore/release-cli-${{ steps.resolve-release-version.outputs.version }} |
Ahhh ok got it! Yep can do, didn't see that. Good point 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Deploying tutorialkit-demo-page with
|
Latest commit: |
00d9caf
|
Status: | ✅ Deploy successful! |
Preview URL: | https://644320bf.tutorialkit-demo-page.pages.dev |
Branch Preview URL: | https://d3lm-patch-1.tutorialkit-demo-page.pages.dev |
Tiny update to the PR description for the release PR. Noticed there was punctuation missing at the end 🙈.