Skip to content

chore: update release workflow #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 4, 2024
Merged

chore: update release workflow #116

merged 7 commits into from
Jul 4, 2024

Conversation

d3lm
Copy link
Contributor

@d3lm d3lm commented Jul 4, 2024

Tiny update to the PR description for the release PR. Noticed there was punctuation missing at the end 🙈.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@d3lm d3lm requested a review from AriPerkkio July 4, 2024 07:50
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI's PR commit has same issue:

- name: Create Pull Request
uses: peter-evans/create-pull-request@v6
with:
# Note: `publish-release.yaml` checks explicitly for this commit message
commit-message: 'chore: release tutorialkit CLI, version: ${{ steps.resolve-release-version.outputs.version }}'
title: 'chore: release tutorialkit CLI, version: ${{ steps.resolve-release-version.outputs.version }}'
body: 'Bump tutorialkit CLI to version ${{ steps.resolve-release-version.outputs.version }}'
reviewers: SamVerschueren,d3lm,Nemikolh,AriPerkkio
branch: chore/release-cli-${{ steps.resolve-release-version.outputs.version }}

@d3lm
Copy link
Contributor Author

d3lm commented Jul 4, 2024

Wait, what do you mean has some issues?

@AriPerkkio
Copy link
Member

I mean let's apply this same change to CLI's PR comments. It's also missing the dot.

      - name: Create Pull Request
        uses: peter-evans/create-pull-request@v6
        with:
          # Note: `publish-release.yaml` checks explicitly for this commit message
          commit-message: 'chore: release tutorialkit CLI, version: ${{ steps.resolve-release-version.outputs.version }}'
          title: 'chore: release tutorialkit CLI, version: ${{ steps.resolve-release-version.outputs.version }}'
-         body: 'Bump tutorialkit CLI to version ${{ steps.resolve-release-version.outputs.version }}'
+         body: 'Bump tutorialkit CLI to version ${{ steps.resolve-release-version.outputs.version }}.'
          reviewers: SamVerschueren,d3lm,Nemikolh,AriPerkkio
          branch: chore/release-cli-${{ steps.resolve-release-version.outputs.version }}

@d3lm
Copy link
Contributor Author

d3lm commented Jul 4, 2024

Ahhh ok got it! Yep can do, didn't see that. Good point 👍

@d3lm d3lm requested a review from AriPerkkio July 4, 2024 08:33
@d3lm d3lm requested a review from AriPerkkio July 4, 2024 08:55
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link

cloudflare-workers-and-pages bot commented Jul 4, 2024

Deploying tutorialkit-demo-page with  Cloudflare Pages  Cloudflare Pages

Latest commit: 00d9caf
Status: ✅  Deploy successful!
Preview URL: https://644320bf.tutorialkit-demo-page.pages.dev
Branch Preview URL: https://d3lm-patch-1.tutorialkit-demo-page.pages.dev

View logs

@Nemikolh Nemikolh merged commit 07d23c1 into main Jul 4, 2024
8 checks passed
@Nemikolh Nemikolh deleted the d3lm-patch-1 branch July 4, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants