docs: add react component docs #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AriPerkkio
reviewed
Jul 8, 2024
docs/tutorialkit.dev/src/content/docs/reference/react-components.mdx
Outdated
Show resolved
Hide resolved
docs/tutorialkit.dev/src/components/react-examples/ExampleFileTree.tsx
Outdated
Show resolved
Hide resolved
docs/tutorialkit.dev/src/content/docs/reference/react-components.mdx
Outdated
Show resolved
Hide resolved
docs/tutorialkit.dev/src/content/docs/reference/react-components.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Ari Perkkiö <[email protected]>
Deploying tutorialkit-docs-page with
|
| Latest commit: |
da5da7d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://753acf83.tutorialkit-docs-page.pages.dev |
| Branch Preview URL: | https://joan-react-comp-docs.tutorialkit-docs-page.pages.dev |
Deploying tutorialkit-demo-page with
|
| Latest commit: |
2a1be0c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6247949a.tutorialkit-demo-page.pages.dev |
| Branch Preview URL: | https://joan-react-comp-docs.tutorialkit-demo-page.pages.dev |
|
There's some weird white box caused by scroll overflows - do you see this too? 
|
|
@AriPerkkio Oh good catch! I had a similar issue with the code blocks. I'll move the hack there too. It's only a chrome issue 😞 |
AriPerkkio
reviewed
Jul 10, 2024
docs/tutorialkit.dev/src/content/docs/reference/react-components.mdx
Outdated
Show resolved
Hide resolved
docs/tutorialkit.dev/src/content/docs/reference/react-components.mdx
Outdated
Show resolved
Hide resolved
docs/tutorialkit.dev/src/components/react-examples/ExampleCodeMirrorEditor.tsx
Outdated
Show resolved
Hide resolved
AriPerkkio
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds docs for TutorialKit React components.
While writing those docs I noticed several improvements we could make:
unocssin order to get a style with all the required classes. After discussing this issue with @d3lm, we thought we could generate a CSS file that would be shipped as part of the@tutorialkit/components-react.FileTree(maybe even per file type?)CodeMirrorEditor: dark / light theme, code mirror extensions