Skip to content

chore: release @tutorialkit packages v0.0.1-alpha.25 #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 9, 2024

Bump @tutorialkit packages to version 0.0.1-alpha.25 and generate changelogs.

Copy link

cloudflare-workers-and-pages bot commented Jul 9, 2024

Deploying tutorialkit-demo-page with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2b47bad
Status: ✅  Deploy successful!
Preview URL: https://6ca452aa.tutorialkit-demo-page.pages.dev
Branch Preview URL: https://chore-release-0-0-1-alpha-25.tutorialkit-demo-page.pages.dev

View logs

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@@ -1,3 +1,38 @@
## [0.0.1-alpha.25](https://github.com/stackblitz/tutorialkit/compare/0.0.1-alpha.23...0.0.1-alpha.25) (2024-07-09)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nemikolh any ideas why this comparison (and changelogs itself) start from 23 and not 24?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because the tag was never pushed. If we push the 0.0.1-alpha.24 tag and re-run the changelog it should work

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I just noticed that there's a bug in our workflow. It push a tag with v in front causing this to fail.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The v is intended 😄
When you run npm version patch, it adds v prefix.

ari ~/Git/aria-live-capture (master) $ npm version patch
v2.0.1
ari ~/Git/aria-live-capture (master) $ git tag
v2.0.0
v2.0.1

Looking at docs of conventional-commits I think it uses that as default, right? https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-changelog-core#tagprefix

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't know! I guess we can revisit that then 👍

In the meantime, I pushed the tag so it should work now if we re-run the job.

@AriPerkkio
Copy link
Member

Let's retry this after #121

@AriPerkkio AriPerkkio closed this Jul 9, 2024
@AriPerkkio AriPerkkio deleted the chore/release-0.0.1-alpha.25 branch July 9, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants