Skip to content

fix(ci): use PAT to make sure release PRs trigger workflows #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

Nemikolh
Copy link
Member

@Nemikolh Nemikolh commented Jul 9, 2024

This PR replace the default use of the GITHUB_TOKEN with GITOPS_REPO_PAT which means that release PRs should now properly trigger workflows.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@Nemikolh Nemikolh requested review from AriPerkkio and apai4 July 9, 2024 16:57
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need same here:

- name: Create Pull Request
uses: peter-evans/create-pull-request@v6
with:
# Note: `publish-release.yaml` checks explicitly for this commit message
commit-message: 'chore: release `@tutorialkit` packages v${{ inputs.version }}'
title: 'chore: release `@tutorialkit` packages v${{ inputs.version }}'
body: 'Bump `@tutorialkit` packages to version ${{ inputs.version }} and generate changelogs.'
reviewers: SamVerschueren,d3lm,Nemikolh,AriPerkkio
branch: chore/release-${{ inputs.version }}

@Nemikolh Nemikolh requested a review from AriPerkkio July 9, 2024 18:02
@d3lm d3lm changed the title fix(CI): use PAT to make sure release PRs trigger workflows fix(ci): use PAT to make sure release PRs trigger workflows Jul 9, 2024
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

One thing that comes to mind though - should we lock version of the Github action to specific commit? I'm always a bit worried when passing secrets to custom Github Actions that use tag as version. So something like:

 - name: Create Pull Request
   uses: peter-evans/create-pull-request@<git-commit-hash-here>

@Nemikolh Nemikolh requested a review from AriPerkkio July 10, 2024 07:33
Copy link

cloudflare-workers-and-pages bot commented Jul 10, 2024

Deploying tutorialkit-demo-page with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5526935
Status: ✅  Deploy successful!
Preview URL: https://962dfb0d.tutorialkit-demo-page.pages.dev
Branch Preview URL: https://joan-ci-use-pat.tutorialkit-demo-page.pages.dev

View logs

@Nemikolh Nemikolh merged commit 5e1a8bc into main Jul 10, 2024
9 checks passed
@Nemikolh Nemikolh deleted the joan/ci-use-pat branch July 10, 2024 08:38
@AriPerkkio
Copy link
Member

The token is missing: https://github.com/stackblitz/tutorialkit/actions/runs/9908586698/job/27374683334

@Nemikolh @apai4

@AriPerkkio AriPerkkio mentioned this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants