-
Notifications
You must be signed in to change notification settings - Fork 84
fix(ci): use PAT to make sure release PRs trigger workflows #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need same here:
tutorialkit/.github/workflows/prepare-release.yaml
Lines 33 to 41 in 3ccfcc2
- name: Create Pull Request | |
uses: peter-evans/create-pull-request@v6 | |
with: | |
# Note: `publish-release.yaml` checks explicitly for this commit message | |
commit-message: 'chore: release `@tutorialkit` packages v${{ inputs.version }}' | |
title: 'chore: release `@tutorialkit` packages v${{ inputs.version }}' | |
body: 'Bump `@tutorialkit` packages to version ${{ inputs.version }} and generate changelogs.' | |
reviewers: SamVerschueren,d3lm,Nemikolh,AriPerkkio | |
branch: chore/release-${{ inputs.version }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
One thing that comes to mind though - should we lock version of the Github action to specific commit? I'm always a bit worried when passing secrets to custom Github Actions that use tag as version. So something like:
- name: Create Pull Request
uses: peter-evans/create-pull-request@<git-commit-hash-here>
Deploying tutorialkit-demo-page with
|
Latest commit: |
5526935
|
Status: | ✅ Deploy successful! |
Preview URL: | https://962dfb0d.tutorialkit-demo-page.pages.dev |
Branch Preview URL: | https://joan-ci-use-pat.tutorialkit-demo-page.pages.dev |
This PR replace the default use of the
GITHUB_TOKEN
withGITOPS_REPO_PAT
which means that release PRs should now properly trigger workflows.