-
Notifications
You must be signed in to change notification settings - Fork 85
feat: add "Edit this page" link #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
845f34e
to
83bef8e
Compare
83bef8e
to
71c10f4
Compare
docs/tutorialkit.dev/src/content/docs/reference/configuration.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! 😃
One immediate feedback that comes to mind is regarding the use of :path
. I think I see where this is coming from but I would prefer if we used ${path}
because:
- It's not behaving as route parameters in express-like servers where
:path
would only match a segment (so only until the next/
). Here it instead does a string replace. - To use the same convention everywhere. If we're sold on using
${variable}
for string interpolation in the metadata then let's use it everywhere we need that feature.
Note that I'm also open to a different syntax. I picked ${variable}
initially because it's similar to JavaScript's template literal syntax.
docs/tutorialkit.dev/src/content/docs/reference/configuration.mdx
Outdated
Show resolved
Hide resolved
dccc2ad
to
b641643
Compare
I've changed the pattern to |
b641643
to
14754c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!! Really good work on this 🤩
Love it ❤️
Adds support for "Edit this page" link.
Inherited
editPageLink
can be disabled on lower hierarcy:See bottom-left corner: