Skip to content

fix: a transition-theme class was missing for the content right border #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

Nemikolh
Copy link
Member

This PR adds a missing transition-theme class on the border. Thanks @d3lm for the find! 😃

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

Deploying tutorialkit-demo-page with  Cloudflare Pages  Cloudflare Pages

Latest commit: 639fbd8
Status: ✅  Deploy successful!
Preview URL: https://ab2fded8.tutorialkit-demo-page.pages.dev
Branch Preview URL: https://joan-fix-border-transition.tutorialkit-demo-page.pages.dev

View logs

@Nemikolh Nemikolh requested a review from AriPerkkio July 15, 2024 12:37
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I wonder if there's an easier way to add this class everywhere. Maybe its rules should automatically be applied on each color class. 🤔

@Nemikolh
Copy link
Member Author

@AriPerkkio I think we could definitely do that and I'm torn a bit on that one.

I was thinking of doing that at first but I changed my mind mainly because it's less explicit and it can have unintended side effects. For instance on components added by end users where maybe they want to control the transition and can't easily because of our plugin.

It also might have a perf impact if it's on everything but it would have some annoying side effects.

Instead of answering all of those questions, I took the simplest and more explicit approach. I don't think it's too bad tbqh.

@Nemikolh Nemikolh merged commit c75ef40 into main Jul 15, 2024
9 checks passed
@Nemikolh Nemikolh deleted the joan/fix-border-transition branch July 15, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants