feat: add 'Open in StackBlitz'-button #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AriPerkkio
changed the title
AriPerkkio
commented
Aug 6, 2024
Comment on lines
16
to
17
| // initialize handlers on each page load as it's possible some pages disable openInStackBlitzLink | ||
| document.addEventListener('astro:page-load', onInit); |
There was a problem hiding this comment.
This is required even when transition:persist is used due to:
- Disable
openInStackBlitzLinkon a single lesson - Open that lesson in fresh browser tab. The element is not mounted and scripts are not run.
- Navigate to a page that doesn't have
openInStackBlitzLinkdisabled. Script tags are not run (due to ViewTransition I think), handler is not attached.
Using page-load works always.
AriPerkkio
commented
Aug 6, 2024
packages/astro/src/default/components/OpenInStackblitzLink.astro
Outdated
Show resolved
Hide resolved
|
Really cool PR! A few things we should do:
The rest is really great! I really love the idea of generating a "start" command in the |
|
Added |
Nemikolh
reviewed
Aug 6, 2024
packages/astro/src/default/components/OpenInStackblitzLink.astro
Outdated
Show resolved
Hide resolved
Nemikolh
reviewed
Aug 7, 2024
Nemikolh
approved these changes
Aug 7, 2024
docs/tutorialkit.dev/src/content/docs/reference/configuration.mdx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an button on top bar that can be used to open current lesson and template code in separate StackBlitz project. Current code from editor is applied on top of the files.
Users can disable showing this button by defining
openInStackBlitzLink: falsein frontmatter metada. By default it's always visible.