-
Notifications
You must be signed in to change notification settings - Fork 85
fix(astro): resolve Astro's private APIs properly #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
01a5687
fix(astro): don't import Astro's private modules
AriPerkkio e2f8aa6
test: udpate snapshots
AriPerkkio 3d3032d
fix(astro): resolve Astro's private APIs properly
AriPerkkio e757484
fix: code review
AriPerkkio bfa5a54
fix: code review
AriPerkkio e987eef
fix: windows paths
AriPerkkio c907e47
fix: windows paths
AriPerkkio e0fe0ff
fix: code review
AriPerkkio 8cfd699
Merge branch 'main' into fix/npm-workspace
AriPerkkio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
/** | ||
* A plugin for importing Astro's private 'transitions/swap-functions.js' module. | ||
* This is temporary solution and can break at any time when end-user's update their `astro` version. | ||
*/ | ||
import { createRequire } from 'node:module'; | ||
import { resolve, sep } from 'node:path'; | ||
import type { VitePlugin } from '../types.js'; | ||
|
||
const require = createRequire(import.meta.url); | ||
const astroDist = resolve(require.resolve('astro/package.json'), '..'); | ||
AriPerkkio marked this conversation as resolved.
Show resolved
Hide resolved
|
||
const swapFunctionEntry = resolve(astroDist, 'dist/transitions/swap-functions.js').replaceAll(sep, '/'); | ||
|
||
const virtualModuleId = 'tutorialkit:astro-swap-functions'; | ||
const resolvedId = `\0${virtualModuleId}`; | ||
|
||
export function astroSwapFunctions(): VitePlugin { | ||
return { | ||
name: 'tutorialkit-astro-swap-functions-plugin', | ||
resolveId(id) { | ||
if (id === virtualModuleId) { | ||
return resolvedId; | ||
} | ||
|
||
return undefined; | ||
}, | ||
|
||
async load(id) { | ||
if (id === resolvedId) { | ||
return `export * from '${swapFunctionEntry}';`; | ||
} | ||
|
||
return undefined; | ||
}, | ||
}; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever!