fix(cli): create-tutorial not depending on @tutorialkit/cli package
#254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AriPerkkio
approved these changes
Aug 18, 2024
There was a problem hiding this comment.
Thanks, good catch! 💯
The latest release of create-tutorial still relies on tutorialkit package, so end-users won't be running into this issue. But it also means that they are stuck on previous versions. I'll publish new release tomorrow. 👍
AriPerkkio
changed the title
create-tutorialcreate-tutorial not depending on @tutorialkit/cli package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
tutorialkitto@tutorialkit/climissing in #153.The PR #153 has been renamed the
@tutorialkit/clidependency inpackage.json, but no changed inindex.ts, if now running locally will see the error:Error: Cannot find module 'tutorialkit', so this PR is fixed this.