Skip to content

fix(astro/types): webcontainer should be a Promise<WebContainer> #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

Nemikolh
Copy link
Member

This PR fixes the type of webcontainer in @tutorialkit/astro/types to be Promise<WebContainer> and not WebContainer.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

cloudflare-workers-and-pages bot commented Aug 18, 2024

Deploying tutorialkit-demo-page with  Cloudflare Pages  Cloudflare Pages

Latest commit: c9b5625
Status: ✅  Deploy successful!
Preview URL: https://1d3f1555.tutorialkit-demo-page.pages.dev
Branch Preview URL: https://joan-fix-astro-types.tutorialkit-demo-page.pages.dev

View logs

@Nemikolh Nemikolh requested a review from AriPerkkio August 18, 2024 15:19
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@Nemikolh Nemikolh merged commit c7bad20 into main Aug 18, 2024
10 checks passed
@Nemikolh Nemikolh deleted the joan/fix-astro-types branch August 18, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants