fix(react): refresh preview when autoReload: true
#303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Nemikolh
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<WorkspacePanel>into 3 internal components #253 (comment)The
PreviewPanelis looking foriframe's inside#preview-panel, but they are actually outside it in the#preview-container. They are just presented there visually with CSS - this is also a serious accessibility issue as tab order doesn't match visual order but this PR doesn't fix that.tutorialkit/packages/react/src/Panels/PreviewPanel.tsx
Lines 52 to 60 in 98ef05b
Recordings of before vs after
Before:
tk-auto-reload-before.webm
After:
tk-auto-reload-after.webm