Skip to content

fix(astro): published package missing @tutorialkit/astro/types #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Sep 24, 2024

The @tutorialkit/astro package is not packing types.d.ts in the package.

"exports": {
".": "./dist/index.js",
"./types": "./types.d.ts",

Generated projects are attempting to use this:

/// <reference path="../.astro/types.d.ts" />
/// <reference types="@tutorialkit/astro/types" />
/// <reference types="astro/client" />

This also blocks type info when using tutorialkit:store in tutorials.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@AriPerkkio
Copy link
Member Author

/pkg-pr-new

@AriPerkkio
Copy link
Member Author

⚡️ Your npm packages are published.

@tutorialkit/astro: npm i https://pkg.pr.new/@tutorialkit/astro@67042ef
@tutorialkit/react: npm i https://pkg.pr.new/@tutorialkit/react@67042ef
@tutorialkit/runtime: npm i https://pkg.pr.new/@tutorialkit/runtime@67042ef
@tutorialkit/theme: npm i https://pkg.pr.new/@tutorialkit/theme@67042ef
@tutorialkit/types: npm i https://pkg.pr.new/@tutorialkit/types@67042ef

@AriPerkkio AriPerkkio marked this pull request as ready for review September 24, 2024 14:57
@AriPerkkio AriPerkkio requested a review from Nemikolh September 24, 2024 14:58
Copy link
Member

@Nemikolh Nemikolh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow good catch! I suppose not that many users tried to create custom components then 😅

@Nemikolh Nemikolh merged commit f49e910 into stackblitz:main Sep 24, 2024
12 checks passed
@AriPerkkio AriPerkkio deleted the fix/astro-types branch September 24, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants