feat(astro): override components to support HeadTags
#375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AriPerkkio
changed the title
HeadTags
AriPerkkio
requested changes
Oct 16, 2024
docs/tutorialkit.dev/src/content/docs/guides/overriding-components.mdx
Outdated
Show resolved
Hide resolved
AriPerkkio
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
This is perfect, thanks @eric-burel! 🤩
Nice to see test cases, docs and everything in place in the PR!
We are planning to do 1.1.0 release later this week. This feature will be part of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was investigating setting up a sitemap, using @astrojs/sitemap.
For a proper setup, you also want to add a
linktag in the pageheadto tell scrapers the URL to your sitemap (in addition to robot.txt). We could do this in the framework default setup, but that would mean setting upsitemapas an integration there and I'd rather give end users more control on the configuration.So I went down the rabbit hole and implemented a replaceable
HeadTagscomponent.I've tried to make the API as future proof as possible using slots.