Skip to content

docs: add filenames to Marking text examples #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

noam-honig
Copy link
Contributor

No description provided.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @noam-honig, thanks for the PR.

Though I'm not sure what this is fixing. So it's switching this:

image

Into this:

image

@noam-honig
Copy link
Contributor Author

@AriPerkkio not exactly, I see my mistake (sorry, I was just editing on github).

The original image confused me - it made me thing the console log should appear twice - I thought it were two examples that are not written correctly.

I fixed it now to be one single example, and also to use title to explain that one is md and the other is code - like other examples in the document.

I hope thats ok

@AriPerkkio
Copy link
Member

This is now not aligned with the other example 🤔

````md title="content.md"
```js title="code.js" ins={4} del={5} {6} "greeting"
const greeting = 'Hello, World!';
// This is a comment
const added = 'This line was added';
const removed = 'This line was removed';
const highlighted = 'This line is highlighted';
```
````
```js title="code.js" ins={4} del={5} {6} "greeting"
const greeting = 'Hello, World!';
// This is a comment
const added = 'This line was added';
const removed = 'This line was removed';
const highlighted = 'This line is highlighted';
```

@noam-honig
Copy link
Contributor Author

Sorry - long day and lots of content switching - I hope its ok now

Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@AriPerkkio AriPerkkio changed the title docs: fixed syntax highlighting of marking text examples docs: add filenames to Marking text examples Nov 8, 2024
@AriPerkkio AriPerkkio merged commit 13b9312 into stackblitz:main Nov 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants