-
Notifications
You must be signed in to change notification settings - Fork 85
chore: bump version and add CHANGELOG.md #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally I like this but this generates only a single changelog (right?) and it'd be nice to have a changelog for all packages that we publish separately IMO. From this changelog it's not clear which feature or bug belongs to which package (unless I click on something I check myself). That's what I mentioned on Slack where a single changelog could work if we enforced scopes where the scope is the package so it's immediately clear where it belongs to.
@d3lm Ah got it! Makes tons of sense 🙏 The Do you think that's worth pursuing? |
Yea I think that would be cool! Having one changelog for every package we publish is prolly desirable and if we can use |
From my observation, with the ## Features
<!-- A commit like "feat: foobar (#123)" seems to land here: -->
* foobar ([#123](<link PR>)) ([<commit hash>](<link commit>)) They seems to have support for other presets and the ability to have our own! 🤯 I can experiement with the presets and let you know what we get for each if you want! 😃 |
I think if it's separated into separate sections then it should be fine 👍 Thanks for checking. |
a906b24
to
000f128
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
This PR introduces
conventional-changelog
to update automatically theCHANGELOG.md
file based on the git history.To create a new version in the changelog, one must do:
version
field in every packagepnpm changelog
CHANGELOG.md
and add shoutouts for our awesome external contributors 🥳