-
Notifications
You must be signed in to change notification settings - Fork 85
chore: add tests to runtime #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments, but looks very good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment, other than that, really love the fact that we have much more tests!
@@ -1,3 +1,4 @@ | |||
pnpm-lock.yaml | |||
.astro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't .astro
files be gitignored?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .astro
folder is ignored already, I noticed that prettier was giving a warning locally because it doesn't ignore it.
It doesn't produce that warning on CI because we run prettier before running the build script. If the order was reversed, the CI would fail which would be a bit silly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OOh weird. Ok, then it's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just two very small questions/remarks.
Co-authored-by: Sam Verschueren <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @Nemikolh 🙏 !
This PR adds tests to the
@tutorialkit/runtime
package and add an helper package,webcontainer-api-mock
to help testing code that uses the WebContainer API.It's minimal at this point but the idea is that it will grow to support
@tutorialkit/components-react
over time.I'm also planning to add more tests for the
runtime
but I wanted to open the PR to start getting feedback on the approach taken with thewebcontainer-api-mock
package.