Skip to content

chore: add tests to runtime #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 19, 2024
Merged

chore: add tests to runtime #75

merged 10 commits into from
Jun 19, 2024

Conversation

Nemikolh
Copy link
Member

This PR adds tests to the @tutorialkit/runtime package and add an helper package, webcontainer-api-mock to help testing code that uses the WebContainer API.

It's minimal at this point but the idea is that it will grow to support @tutorialkit/components-react over time.

I'm also planning to add more tests for the runtime but I wanted to open the PR to start getting feedback on the approach taken with the webcontainer-api-mock package.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jun 17, 2024

⚠️ No Changeset found

Latest commit: 95e5b2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Nemikolh Nemikolh requested a review from SamVerschueren June 17, 2024 17:07
Copy link
Contributor

@SamVerschueren SamVerschueren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, but looks very good!

@Nemikolh Nemikolh requested review from SamVerschueren and d3lm June 18, 2024 12:50
Copy link
Contributor

@SamVerschueren SamVerschueren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment, other than that, really love the fact that we have much more tests!

@Nemikolh Nemikolh requested a review from SamVerschueren June 19, 2024 12:24
@@ -1,3 +1,4 @@
pnpm-lock.yaml
.astro
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't .astro files be gitignored?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .astro folder is ignored already, I noticed that prettier was giving a warning locally because it doesn't ignore it.

It doesn't produce that warning on CI because we run prettier before running the build script. If the order was reversed, the CI would fail which would be a bit silly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOh weird. Ok, then it's fine.

Copy link
Contributor

@SamVerschueren SamVerschueren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just two very small questions/remarks.

@Nemikolh Nemikolh requested a review from SamVerschueren June 19, 2024 13:52
Copy link
Contributor

@SamVerschueren SamVerschueren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @Nemikolh 🙏 !

@Nemikolh Nemikolh merged commit 4c39cc6 into main Jun 19, 2024
6 checks passed
@Nemikolh Nemikolh deleted the joan/runtime-tests branch June 19, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants