docs: add tutorialkit.dev website #78
Conversation
|
|
|
docs/tutorialkit.dev/.gitignore
Outdated
There was a problem hiding this comment.
This file can probably be removed?
There was a problem hiding this comment.
I think I'll keep it for tutorialkit.dev specific files/folders. Like this one also has .env and .env.production. I don't think they are used though, but maybe they are?
The .astro folder is something specific to this folder and I don't think it makes much sense to move that to the root?
So the file would then look like this
# generated types
.astro
# environment variables
.env
.env.production
There was a problem hiding this comment.
Ah good point! Yep let's simplify it but keep it 👍
package.json
Outdated
| @@ -7,6 +7,8 @@ | |||
| "prepare": "is-ci || husky install", | |||
| "template:dev": "TUTORIALKIT_DEV=true pnpm run build && pnpm run --filter=tutorialkit-starter dev", | |||
| "template:build": "pnpm run build && pnpm run --filter=tutorialkit-starter build", | |||
| "tkit": "pnpm run --filter=tutorialkit.dev dev", | |||
There was a problem hiding this comment.
What if this was "docs" instead of "tkit"?
There was a problem hiding this comment.
So first I had docs. It had 2 minor "issues"
- You can't run
pnpm docs, because it opens the pnpm documentation. So you need to runpnpm run docs. - If we are moving the demo over to this repo as well, it might be confusing?
I don't know, it's not big of a deal and we could always just have pnpm run demo and pnpm run docs. Maybe that's better?
There was a problem hiding this comment.
Oh I quite like pnpm run demo and pnpm run docs! 🌟
It's a bummer that pnpm docs doesn't work. Maybe we could have docs-site instead?
Although I think I prefer pnpm run docs to pnpm docs-site.
There was a problem hiding this comment.
Yeah I agree. I'll update it.
This PR moves the website from
tutorialkit.devinto this repository.I moved it inside the
docs/tutorialkit.devfolder. The reason I didn't move it directly intodocsis because we also want to move the demo inside this repository, which I would put underdocs/demo. I'm open to suggestions though. We could also dodocsanddemoin the root of the project for instance.