Skip to content

feat(theme): create proper tokens for callouts #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Conversation

SamVerschueren
Copy link
Contributor

I'm documenting the theming aspect of TutorialKit and noticed that it's pretty hard to change the colors of the callouts specifically.

That's why I extracted them per type into variables.css and referenced them in markdown.css. This way, it's easier for a user to overwrite specific colors.

One thing I wasn't sure about was if I needed to add them to theme.ts? The variables are not used by uno-css (yet) because we just reference them in markdown.css. But should I already add them?

I also noticed that there are even more things in markdown.css which we might want to expose later in regards to styling codeblocks and what not. But I left that out for now.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jun 20, 2024

⚠️ No Changeset found

Latest commit: 9fce107

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

cloudflare-workers-and-pages bot commented Jun 20, 2024

Deploying tutorialkit-demo-page with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ac1509
Status: ✅  Deploy successful!
Preview URL: https://c57387e8.tutorialkit-demo-page.pages.dev
Branch Preview URL: https://feat-theming-callouts.tutorialkit-demo-page.pages.dev

View logs

@donmckenna
Copy link

I think Dom would know better regarding the uno-css question, but otherwise lgtm ❤️

@d3lm
Copy link
Contributor

d3lm commented Jun 24, 2024

Yep looks good. We don't need to define them in theme.ts since we don't use those more specific variables as CSS classes 👍

@d3lm d3lm merged commit 6d01620 into main Jun 24, 2024
7 checks passed
@d3lm d3lm deleted the feat/theming/callouts branch June 24, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants