Skip to content

fix: support a base different from / in astro config #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 25, 2024

Conversation

Nemikolh
Copy link
Member

This PR makes it possible to use a base different from / in Astro configuration.

Closes #89

@Nemikolh Nemikolh requested review from SamVerschueren and d3lm June 24, 2024 15:25
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jun 24, 2024

⚠️ No Changeset found

Latest commit: 78c642e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Nemikolh Nemikolh force-pushed the joan/base-deploy-path branch from 0bedd26 to fcab467 Compare June 24, 2024 15:26
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will also solve hosting TutorialKit on Github Pages 🎉

@Nemikolh Nemikolh requested a review from AriPerkkio June 24, 2024 18:01
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Here's deployment made with these changes: https://ariperkkio.github.io/tutorial-vite-plugin

@Nemikolh Nemikolh requested a review from SamVerschueren June 25, 2024 09:20
@Nemikolh Nemikolh requested a review from SamVerschueren June 25, 2024 11:44
@Nemikolh Nemikolh requested a review from d3lm June 25, 2024 12:02
Copy link

cloudflare-workers-and-pages bot commented Jun 25, 2024

Deploying tutorialkit-demo-page with  Cloudflare Pages  Cloudflare Pages

Latest commit: a78ce3c
Status:🚫  Build failed.

View logs

Copy link

Deploying tutorialkit-docs-page with  Cloudflare Pages  Cloudflare Pages

Latest commit: a78ce3c
Status:🚫  Build failed.

View logs

@Nemikolh Nemikolh merged commit 3e7830b into main Jun 25, 2024
7 checks passed
@Nemikolh Nemikolh deleted the joan/base-deploy-path branch June 25, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base deploy path
4 participants