-
Notifications
You must be signed in to change notification settings - Fork 85
feat: allow custom src/pages/index.astro
#93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Deploying tutorialkit-demo-page with
|
Latest commit: |
23ceb9d
|
Status: | ✅ Deploy successful! |
Preview URL: | https://6f733e44.tutorialkit-demo-page.pages.dev |
Branch Preview URL: | https://joan-default-route.tutorialkit-demo-page.pages.dev |
Deploying tutorialkit-docs-page with
|
Latest commit: |
23ceb9d
|
Status: | ✅ Deploy successful! |
Preview URL: | https://e0110403.tutorialkit-docs-page.pages.dev |
Branch Preview URL: | https://joan-default-route.tutorialkit-docs-page.pages.dev |
When adding these things we need to make sure to add this to the docs as well and it'd be great if we can link the docs PR here as well for full transparency. |
It'd be better to just update the docs in this PR. So it's a single PR which includes everything. |
Right! Forgot for a second that the docs are in the same repo 🤦♂️ |
@d3lm, @SamVerschueren I've updated the JSDoc of the property so that the new value is explained. Given we currently don't have any docs on https://tutorialkit.dev for our JSDocs I don't think it makes sense that I introduce that as part of this PR? What do you think? |
This PR makes it possible to have a custom
src/pages/index.astro
by modifying thedefaultRoutes
to support an extra mode in which it does not inject the default route for/{base}
.Once this PR is merged, to enable this feature on a project, one would have to do:
The alternative to this I considered was to modify
index.astro
so that it reads file from thesrc/pages/index.astro
folder, however this wouldn't have worked under theeject
mode as the file would end up reading itself recursively.