-
Notifications
You must be signed in to change notification settings - Fork 85
fix(theme): set correct background and text color for panels #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Deploying tutorialkit-docs-page with
|
Latest commit: |
0f8732f
|
Status: | ✅ Deploy successful! |
Preview URL: | https://f1d13ab5.tutorialkit-docs-page.pages.dev |
Branch Preview URL: | https://fix-theme-panel-background-a.tutorialkit-docs-page.pages.dev |
Deploying tutorialkit-demo-page with
|
Latest commit: |
078f726
|
Status: | ✅ Deploy successful! |
Preview URL: | https://62a20714.tutorialkit-demo-page.pages.dev |
Branch Preview URL: | https://fix-theme-panel-background-a.tutorialkit-demo-page.pages.dev |
I think I haven't used the panel background because it's was not used in the Figma design. So if we change the system to use the panel background instead of the app background then we need to update the design file as well. Maybe that was just by accident @donmckenna or was there a particular reason to not use the panel background token?
Personally I would say the left side (tutorial content) is not a panel because it doesn't have a panel header and it's different from the panels we have on the right. So for the left side I'd say that it is not impacted if you'd change the panel background color and instead is impacted when the app background color gets changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
To be honest, currently the only thing the app background impacts is the background of the steps that are running like "Booting WebContainer" and running the prepare commands. But the terminal has it's own background, and so does the editor. |
Oh yea? Wait, shouldn't the tutorial content background be impacted as well? At least that's how it's defined in Figma 🤔 |
Oh sorry, I was referring to the panel background, my bad. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
When documenting, I noticed that the
--tk-elements-panel-backgroundColor
was not used. I'm not entirely sure if I fixed it in all the correct locations. For instance, is the content on the left also a panel? And thus, should the background be impacted by this token? (currently it's not)I also added a new token to set the default text color of the panel. I figured, if there's a way to specify the background color, there should also be a way to specify the text color. cc @donmckenna We should not forget to add this to figma then.