Skip to content

chore: remove pnpm from tool versions file #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

d3lm
Copy link
Contributor

@d3lm d3lm commented Jun 25, 2024

This PR removes pnpm from the .tool-versions file because it's unfortunately currently unsupported by Cloudflare Pages. Instead I added pnpm to the engines field to enforce a specific version. That version is also enforced in the build options for Cloudflare Pages.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@d3lm d3lm requested a review from Nemikolh June 25, 2024 12:49
Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: c456c7b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@d3lm d3lm requested a review from SamVerschueren June 25, 2024 12:49
Copy link

Deploying tutorialkit-demo-page with  Cloudflare Pages  Cloudflare Pages

Latest commit: f5b6a97
Status: ✅  Deploy successful!
Preview URL: https://223333b8.tutorialkit-demo-page.pages.dev
Branch Preview URL: https://delm-feat-remove-pnpm-from-t.tutorialkit-demo-page.pages.dev

View logs

@d3lm d3lm force-pushed the delm/feat/remove-pnpm-from-tool-versions branch from f5b6a97 to 76787f8 Compare June 25, 2024 12:51
Copy link
Member

@Nemikolh Nemikolh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! 🤩

@@ -25,7 +25,7 @@ jobs:
- name: Setup
uses: pnpm/action-setup@v4
with:
version: 8
version: 8.15.6
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using this version because it's currently the latest we support on StackBlitz.com.

@d3lm d3lm changed the title Delm/feat/remove pnpm from tool versions chore: remove pnpm from tool versions file Jun 25, 2024
@d3lm d3lm merged commit 01fe702 into main Jun 25, 2024
7 checks passed
@d3lm d3lm deleted the delm/feat/remove-pnpm-from-tool-versions branch June 25, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants