Skip to content

feat(theme): add support for setting text and code colors in callouts #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

SamVerschueren
Copy link
Contributor

This PR adds support for 3 new tokens (per callout):

  • --tk-elements-callouts-tip-textColor: Set the text color of the callout
  • --tk-elements-callouts-tip-codeColor: Set the text color of code snippets
  • --tk-elements-callouts-tip-codeBackgroundColor: Set the background color of the code snippets

image

Let me know if you want to rename it to something different or tweak it slightly.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: 648e6bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@Nemikolh Nemikolh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!! 💅

@d3lm
Copy link
Contributor

d3lm commented Jun 25, 2024

We gotta make sure that this is added to the Figma file as well (CC @donmckenna)

Copy link

cloudflare-workers-and-pages bot commented Jun 25, 2024

Deploying tutorialkit-demo-page with  Cloudflare Pages  Cloudflare Pages

Latest commit: 648e6bd
Status: ✅  Deploy successful!
Preview URL: https://3c687305.tutorialkit-demo-page.pages.dev
Branch Preview URL: https://feat-theme-callout-text-and.tutorialkit-demo-page.pages.dev

View logs

@SamVerschueren SamVerschueren merged commit 623b04d into main Jun 25, 2024
8 checks passed
@SamVerschueren SamVerschueren deleted the feat/theme/callout-text-and-code branch June 25, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants