Skip to content

fix(theme): invalid CSS variable on cm-gutter #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2024
Merged

fix(theme): invalid CSS variable on cm-gutter #98

merged 2 commits into from
Jun 26, 2024

Conversation

AriPerkkio
Copy link
Member

Fixes typo on CSS variable.

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0c16f6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Nemikolh
Nemikolh approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@Nemikolh Nemikolh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!! 🤩

@d3lm
Copy link
Contributor

d3lm commented Jun 26, 2024

@AriPerkkio Did you check by any chance if this has some visual impact? Is it still looking correct now that the type was fixed?

@AriPerkkio
Copy link
Member Author

No visual changes. Neither --ts-elements-editor-gutter-backgroundColor or --tk-elements-editor-gutter-backgroundColor is set to any value. The fallback --cm-backgroundColor is used.

@Nemikolh Nemikolh merged commit 039f871 into stackblitz:main Jun 26, 2024
7 checks passed
@AriPerkkio AriPerkkio deleted the fix/editor-css-var branch June 26, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nemikolh Nemikolh Nemikolh approved these changes

@d3lm d3lm d3lm approved these changes

@SamVerschueren SamVerschueren Awaiting requested review from SamVerschueren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AriPerkkio @d3lm @Nemikolh