Specifying pool capacity is now optional. #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR. Do you not need this anymore? |
|
I wasn't sure if I had something wrong given the CI errors I received. After closing the PR I came across a better syntax to use and will submit a PR for that version. If you have any input or other guidance I should consider please let me know. It is a simple change but thought I should ask. |
|
CI errors were due to ansible-lint, fixed in another PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A modified version of pool.xml.j2 will now pass parsing if capacity is omitted. Omitting capacity limits the pool's capacity to it's resident volume's capacity.