Skip to content

Add support for Debian GNU/Linux and derivatives #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2018

Conversation

jovial
Copy link
Contributor

@jovial jovial commented Sep 28, 2018

No description provided.

@@ -18,9 +22,10 @@
state: installed
when: libvirt_host_qemu_emulators | length > 0
become: True
when: ansible_os_family == "RedHat"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double when: use a list

---
# List of libvirt package dependencies.
libvirt_host_libvirt_packages:
- libvirt-bin

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python-lxml and libvirt python required too?

These may be pulled in automatically, but adding them
explicitly just in case.
Copy link

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible.

@jovial jovial changed the title (WIP)Add support for Debian GNU/Linux and derivatives Add support for Debian GNU/Linux and derivatives Oct 3, 2018
@jovial jovial merged commit 3b6df77 into stackhpc:master Oct 3, 2018
@jovial jovial deleted the debian branch October 3, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants