Support Debian based GNU/Linux distributions #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The user `qemu` does not exist on Debian based distributions - libvirt-qemu runs with root permissions so we do not need to change the ownership of the volumes in the storage pool
markgoddard
approved these changes
Oct 1, 2018
| existing_group="$(stat --format '%G' "$output")" | ||
| new_owner="${VOLUME_OWNER:-$existing_owner}" | ||
| new_group="${VOLUME_GROUP:-$existing_group}" | ||
| output=$(chown "$new_owner":"$new_group" $output 2>1) |
There was a problem hiding this comment.
I think you could have just done
if [[ -n $VOLUME_GROUP ]] && [[ -n $VOLUME_OWNER ]]; then
output=$(chown "$VOLUME_OWNER":"$VOLUME_GROUP" $output 2>1
fi
But this works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qemudoes not exist on Debian baseddistributions
do not need to change the ownership of the volumes
in the storage pool