Support for network filesystems. #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgoddard
suggested changes
Feb 20, 2020
In my case it would be ceph but hopefully there are enough switches included that others could be used if desired. I've tested this with RBD volumes. Includes fixes for feedback in in PR ( #48 )
|
The latest commit sits better on this stack than master so I've added it here. |
Should be libvirt_volume_default_type rather than libvirt_volume_default_device.
Fix up confusion between type and device.
markgoddard
approved these changes
Jun 18, 2020
There was a problem hiding this comment.
Sorry for not getting to this sooner Karl. I have pushed some changes to fix up confusion between the type and the device variables. I also removed your commit to run 'Ensure the VM disk volumes exist' for file type volumes - partly because it is unrelated, partly because I'm unsure about it. We've had a lot of churn around that conditional. Please propose it again separately and we can discuss there.
Merged
|
Thanks mark, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my case it would be ceph but hopefully there are enough switches included
that others could be used if desired.
I've tested this with RBD volumes.
Closes #35 .
Maybe Closes #25 .