Fix receiving multicast traffic #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has security implications as it allows mac spoofing. Should it be behind a feature flag? |
By default libvirt does not allow traffic destined for other MAC addresses to reach VMs when using a macvtap interface. This prevents multicast from working. This change allows guest receive filters to be trusted by setting libvirt_vm_trust_guest_rx_filters, or the trust_guest_rx_filters attribute of a specific interface to yes. This maps to the trustGuestRxFilters Libvirt interface option.
markgoddard
force-pushed
the
fix-multicast
branch
from
5574518 to
e7b005c
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default libvirt does not allow traffic destined for other MAC
addresses to reach VMs when using a macvtap interface. This prevents
multicast from working.
This change fixes the issue by setting trustGuestRxFilters to yes for
macvtap interfaces.