Skip to content

Add a option to use checksum on get_url in tasks Ensure remote images are downloaded #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 16, 2020

Conversation

roumano
Copy link
Contributor

@roumano roumano commented Nov 13, 2020

Add a optional new field in volume : checksum, it's will avoid downloading images when it's not need.
Can be use like this :

  volumes:
    - name: 'debian-10.5.0-amd64-netinst.iso'
      image: https://cdimage.debian.org/debian-cd/current/amd64/iso-cd/debian-10.5.0-amd64-netinst.iso
      checksum: sha256:93863e17ac24eeaa347dfb91dddac654f214c189e0379d7c28664a306e0301e7

… are downloaded

via volumes[].checksum optional field
@jovial
Copy link
Contributor

jovial commented Nov 13, 2020

Seems like a nice addition. Should we add it to the example in the README?

@roumano
Copy link
Contributor Author

roumano commented Nov 13, 2020

  • Yes, i have added a information on the README.
  • Also i added the checksum on the copy tasks (not tested as i don't use this but should work too as it's working exactly same as previous tasks)

Copy link

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@markgoddard markgoddard merged commit 9fab5e6 into stackhpc:master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants