Skip to content

Allow no partition definitions #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 28, 2022
Merged

Allow no partition definitions #132

merged 5 commits into from
Apr 28, 2022

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Mar 31, 2022

There's currently an explicit check that openhpc_slurm_partitions has at least one item in it. This makes sense for direct deployment - creating a slurm cluster with no partitions is clearly not very useful. However for image build this is a legitimate case, so this just updates the checks to remove that (and be closer to what the check is stated to be / in line with defaults).

@sjpb sjpb mentioned this pull request Mar 31, 2022
@sjpb
Copy link
Collaborator Author

sjpb commented Mar 31, 2022

Used by stackhpc/ansible-slurm-appliance#160

Copy link
Contributor

@jovial jovial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible

@sjpb sjpb merged commit 1c08015 into master Apr 28, 2022
@sjpb sjpb deleted the no-partitions branch April 28, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants