Skip to content

Supply dashboards from appliance repo (& fix dashboard typos) #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 14, 2022

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Apr 13, 2022

Enables grafana dashboards to be provided in the grafana-dashboards role's files/ directory, rather than downloading from grafana.com.

This makes dashboard development/fixes etc easier, as currently the slurm-integrated dashboards are in @jovial's own grafana account.

Also fixes some typos in the dashboards - fixes #30.

Deployed: vglabs-steveb-ansible-rocky85-ansible:/home/rocky/slurm-app-dev

Tested on sms-labs, dashboards appear to work.

@sjpb sjpb requested a review from jovial April 13, 2022 16:36
@sjpb sjpb changed the title Fix/dashboard typos Supply dashboards from appliance repo (& fix dashboard typos) Apr 14, 2022
Copy link
Collaborator

@jovial jovial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sjpb sjpb merged commit 57c56f6 into main Apr 14, 2022
@sjpb sjpb deleted the fix/dashboard-typos branch April 14, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in dashboards
2 participants