Skip to content

Packer build fixes #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2022
Merged

Packer build fixes #177

merged 2 commits into from
May 4, 2022

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Apr 28, 2022 •
edited
Loading

Couple of fixes for packer builds from experience in non-smslabs environment.

NB: This disables block device configuration. This is probably correct, but needs discussing.

@sjpb sjpb mentioned this pull request Apr 28, 2022
Merged
4 tasks
@sjpb sjpb requested review from m-bull and jovial April 29, 2022 10:33
@sjpb
Copy link
Collaborator Author

sjpb commented May 3, 2022

Need to add some documentation to:

  • Note that block_devices can't work during image build
  • Suggest using cloud-init instead.
  • Point to TF example in aaddf02

@sjpb sjpb changed the base branch from main to feature/control-images2 May 4, 2022 08:03
@sjpb sjpb changed the base branch from feature/control-images2 to feature/offboard-state May 4, 2022 08:10
@sjpb sjpb merged commit 0a6f189 into feature/offboard-state May 4, 2022
@sjpb sjpb deleted the fix/packer-build branch May 4, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bull m-bull Awaiting requested review from m-bull

@jovial jovial Awaiting requested review from jovial

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sjpb