Skip to content

Fix packer build defaults #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Fix packer build defaults #207

merged 1 commit into from
Aug 22, 2022

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Aug 22, 2022

The packer build contains some variables used to proxy through a jumphost - this is unlikely to be needed for real site deployments but is required for CI. This PR adds defaults so that the packer build works when these aren't set.

This is a cherry pick from NREL

@sjpb sjpb requested a review from m-bull August 22, 2022 09:35
@sjpb sjpb marked this pull request as ready for review August 22, 2022 09:35
Copy link
Collaborator

@m-bull m-bull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 49f4a30 into main Aug 22, 2022
@sjpb sjpb deleted the fix/packer-defaults branch August 22, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants