Fix dashboard idempotency #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently running
ansible-playbook ansible/monitoring.yml --tags grafanarepeatedly flip-flops between deploying and removing the grafana dashboards. This PR fixes that.Not picked up by CI as CI cannot check the grafana UI directly - there is no easy way to scrape pages due to their use of javascript.
Note that the logic in
grafana-dashboards/tasks/main.ymlis based on https://github.com/cloudalchemy/ansible-grafana/blob/master/tasks/dashboards.yml#L108, but modified to also allow dashboards to be deployed from local files. However the result of_dashboards_copiedin the current code is not the same as in that "upstream" version due to changes to paths, which has caused this problem.