Skip to content

Use environment hooks when building "fat" image #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Use environment hooks when building "fat" image #255

merged 3 commits into from
Apr 11, 2023

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Mar 16, 2023

This allows for customisation of the "fat" image pipeline by running environment-specific hooks. This is useful for cases where deployments want to build their own fat image, and have some specific requirements.

If hooks need to be prevented from running during any build, use e.g.:

- hosts: compute:!builder 

If hooks should only run in the environment-specific compute image build, not the fat image build, use e.g.:

- hosts: compute:!control:!login

(as the fat image build host is in all 3 groups)

@sjpb sjpb marked this pull request as ready for review March 16, 2023 14:10
@sjpb sjpb requested a review from m-bull March 22, 2023 19:53
Copy link
Collaborator

@m-bull m-bull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit f925f93 into main Apr 11, 2023
@sjpb sjpb deleted the fix/fatimage branch April 11, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants