Skip to content

Re-enable NetworkManager control of resolv.conf after image build #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 13, 2023
Merged

Re-enable NetworkManager control of resolv.conf after image build #258

merged 6 commits into from
Apr 13, 2023

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Apr 12, 2023 •
edited
Loading

  • Fixes fat image has NM control of /etc/resolv.conf disabled #257, producing a fat image which should work on OpenStack subnets with or without dns_nameservers defined.
  • Makes cleanup of injected ssh config during build depend on ansible_user, rather than being hard-coded to rocky.
  • Fixes previously-untried fat image build workflow.

@sjpb sjpb marked this pull request as ready for review April 12, 2023 10:32
@sjpb sjpb requested review from sd109 and m-bull April 12, 2023 10:32
@sjpb
Copy link
Collaborator Author

sjpb commented Apr 12, 2023

Image build run: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/4677339273

m-bull
m-bull reviewed Apr 12, 2023
View reviewed changes
@sjpb sjpb marked this pull request as draft April 12, 2023 11:42
@sjpb
Copy link
Collaborator Author

sjpb commented Apr 12, 2023

Sorry @m-bull @sd109 I flagged this too early, need to get image build going then test on arcus, and push new image through this CI.

@sjpb
Copy link
Collaborator Author

sjpb commented Apr 12, 2023

Fat image build at 44c4a59: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/4679356388/jobs/8289267649, produced openhpc-230412-1447-e3769af6.qcow2

@sjpb
Copy link
Collaborator Author

sjpb commented Apr 13, 2023 •
edited
Loading

@sd109 can you try this image on smslabs please and report here if it has a working resolv.conf on boot? arcus s3://openhpc-images-prerelease/openhpc-230412-1447-e3769af6.qcow2

(edited to fix link)

@sjpb
Copy link
Collaborator Author

sjpb commented Apr 13, 2023 •
edited
Loading

@sd109 reported this worked as expected on smslabs subnet with no dns_nameservers defined.

@sjpb sjpb marked this pull request as ready for review April 13, 2023 15:16
@sjpb
Copy link
Collaborator Author

sjpb commented Apr 13, 2023

@m-bull @sd109 can someone hit approve on this pls?

@sjpb sjpb merged commit dcf2d1d into main Apr 13, 2023
@sjpb sjpb deleted the fix/resolv branch April 13, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bull m-bull m-bull left review comments

@sd109 sd109 sd109 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fat image has NM control of /etc/resolv.conf disabled
3 participants
@sjpb @m-bull @sd109