Skip to content

Make CI cloud selectable between SMSlabs and Arcus #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 21, 2023
Merged

Make CI cloud selectable between SMSlabs and Arcus #288

merged 14 commits into from
Jul 21, 2023

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Jul 18, 2023 •
edited
Loading

  • Run CI on either Arcus or sms-labs: set the new actions variable "CI_CLOUD" to SMS or ARCUS.
  • Skeleton Terraform now supports volume-backed instances.

@sjpb sjpb requested a review from a team as a code owner July 18, 2023 11:21
@sjpb sjpb force-pushed the ci/smslabs branch 5 times, most recently from a460bbb to 8ffe250 Compare July 18, 2023 12:08
@sjpb sjpb requested review from sd109 and m-bull July 21, 2023 12:11
sd109
sd109 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@sd109 sd109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 3a53585 into main Jul 21, 2023
@sjpb sjpb deleted the ci/smslabs branch July 21, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sd109 sd109 sd109 approved these changes

@m-bull m-bull Awaiting requested review from m-bull

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjpb @sd109