Make nvidia-driver install idempotent #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bull
requested changes
Oct 6, 2023
This was referenced Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the install of the
nvidia-drivermodule by the CUDA role idempotent, so that the module's packages are not updated by rerunning the role.If using the
nvidia-driver:latest-dkmsmodule stream, runningdnf module install nvidia-driverwill update drivers if more recent ones become available. This is in contrast to non-modulardnf install $package_namebehaviour, where installed packages are not updated by rerunning the command.This PR changes the role to check if a nvidia-driver module is enabled, and only if not, search for the highest-numbered dkms-variant module stream and enable that.