-
Notifications
You must be signed in to change notification settings - Fork 34
Merge caas slurm appliance into slurm appliance #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…83b31bf2508830052c3bf
…-slurm-appliance#43
42544aa
to
85b2feb
Compare
…nary_path anymore
Tests @ b78f1e4
On azimuth cluster - sb-tf1:
Tests on stackhpc environment:
|
m-bull
reviewed
Nov 24, 2023
m-bull
approved these changes
Nov 24, 2023
This was referenced Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces https://github.com/stackhpc/caas-slurm-appliance with a
.caas
environment.Requires https://github.com/stackhpc/azimuth-caas-operator/pull/75 and azimuth-cloud/ansible-collection-azimuth-ops#202. Note that:
environments/.caas/
ansible/site.yml
Both normal and "fast-volume-type" clusters are supported, by using the appropriate ui-meta file.
Currently the ansible-driven image build functionality from CaaS has not been ported to this repo - use the github workflow or or packer configurations directly.
Implementation Notes
activate
script, so:ansible.cfg
is provided in the repo root, as expected by caas operator.ANSIBLE_INVENTORY
is set in the cluster type template, using a relative path:ansible_inventory_sources
which contains absolute paths, and that is used to derive theappliances_environment_root
. This needed some changes in site.yml where the environment varAPPLIANCES_ENVIRONMENT_ROOT
is not available in caas. Note this environment var can't be got rid of entirely yet because{TF,PKR}_VAR_environment_root
are derived from it in non-caas environments).if 'grafana' in groups
-->if groups[‘grafana’] | length > 0
which means lots of caas-specific overrides could be removed.common
env ondemand config didn’t always take into account whether grafana was deployed, which caas did (see 2b264c7).basic_users
andetc_hosts
roles are used instead of custom code in the original caas repo.TODO
Merge following from CaaS: