Skip to content

Use most-recent image in skeleton terraform if multiple found #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2024
Merged

Use most-recent image in skeleton terraform if multiple found #350

merged 2 commits into from
Jan 17, 2024

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Jan 12, 2024 •
edited
Loading

Sometimes terraform apply in the Arcus CI project with the stackhpc environment fails with

│ Error: Your query returned more than one result. Please try a more specific search criteria, or set `most_recent` attribute to true.

This fixes this by a) making all image parameters use the image uid and b) finding those images using terraform's most_recent option.

@sjpb sjpb marked this pull request as ready for review January 16, 2024 14:25
@sjpb sjpb requested a review from a team as a code owner January 16, 2024 14:25
sd109
sd109 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@sd109 sd109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 2d78fc9 into main Jan 17, 2024
@sjpb sjpb deleted the fix/multi-images branch January 17, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sd109 sd109 sd109 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjpb @sd109