Skip to content

Require user SSH key to be available in ui-meta #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 9, 2024
Merged

Require user SSH key to be available in ui-meta #356

merged 2 commits into from
Feb 9, 2024

Conversation

JohnGarbutt
Copy link
Member

@JohnGarbutt JohnGarbutt commented Feb 7, 2024 •
edited by sjpb
Loading

explanation by @sjpb:

  • AWX driver defaulted this true. CaaS operator defaults it to false.
  • Hit on new cloud. Hadn't been hit as users/CI user always had a key defined.

@JohnGarbutt JohnGarbutt marked this pull request as ready for review February 7, 2024 15:33
@JohnGarbutt JohnGarbutt requested a review from a team as a code owner February 7, 2024 15:33
@sjpb sjpb requested a review from mkjpryor February 9, 2024 16:08
sd109
sd109 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@sd109 sd109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mkjpryor
mkjpryor approved these changes Feb 9, 2024
View reviewed changes
Copy link

@mkjpryor mkjpryor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkjpryor mkjpryor changed the title Add requires_ssh_key:true into ui meta Require user SSH key to be available in ui-meta Feb 9, 2024
@sjpb sjpb merged commit b065088 into main Feb 9, 2024
@sjpb sjpb deleted the add-require-ssh branch February 9, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkjpryor mkjpryor mkjpryor approved these changes

@sd109 sd109 sd109 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JohnGarbutt @mkjpryor @sd109 @sjpb