Skip to content

Define compute groups in Tofu #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2024
Merged

Define compute groups in Tofu #390

merged 5 commits into from
May 15, 2024

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented May 14, 2024

Allow homogenous compute groups to be defined in the skeleton Tofu more naturally and with different vnic types, bindings and image IDs between groups. This makes cookiecutter-produced environments more production-ready.

Also changes volume attach logic to use name rather than description, as description is not available on volume data resources.

@sjpb sjpb force-pushed the feat/tf-compute-groups branch from 619b8ce to cef0d18 Compare May 14, 2024 15:41
@sjpb sjpb marked this pull request as ready for review May 15, 2024 07:57
@sjpb sjpb requested a review from a team as a code owner May 15, 2024 07:57
Copy link
Collaborator

@m-bull m-bull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 8a9b6a3 into main May 15, 2024
1 check passed
@sjpb sjpb deleted the feat/tf-compute-groups branch May 15, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants