Skip to content

Add workflow for fat image uploads to client sites #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Aug 27, 2024

Conversation

bertiethorpe
Copy link
Member

No description provided.

@bertiethorpe bertiethorpe force-pushed the feat/fatimage-auto-upload branch 13 times, most recently from 681bd36 to 4ff42ce Compare August 21, 2024 16:30
@bertiethorpe bertiethorpe force-pushed the feat/fatimage-auto-upload branch from 4ff42ce to 0b9a219 Compare August 22, 2024 08:56
@bertiethorpe
Copy link
Member Author

@bertiethorpe bertiethorpe force-pushed the feat/fatimage-auto-upload branch from 04e30fc to d044560 Compare August 22, 2024 15:38
@bertiethorpe bertiethorpe changed the title Automated workflow for fat image uploads to client sites Workflow disptach for fat image uploads to client sites Aug 22, 2024
@bertiethorpe
Copy link
Member Author

In the future it would be nice to search for release images when there are merges to main, but this requires searching for images in the terraform which have different directory structures between clients

@bertiethorpe bertiethorpe requested a review from sd109 August 23, 2024 08:38
@bertiethorpe bertiethorpe marked this pull request as ready for review August 23, 2024 08:38
@bertiethorpe bertiethorpe requested a review from a team as a code owner August 23, 2024 08:38
@sd109 sd109 changed the title Workflow disptach for fat image uploads to client sites Add workflow for fat image uploads to client sites Aug 23, 2024
Copy link
Member

@sd109 sd109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just some minor comments and suggestions.

@bertiethorpe bertiethorpe requested a review from sd109 August 23, 2024 11:11
Copy link
Member

@sd109 sd109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work.

@bertiethorpe bertiethorpe merged commit 513ad1c into main Aug 27, 2024
1 check passed
@bertiethorpe bertiethorpe deleted the feat/fatimage-auto-upload branch August 27, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants