Skip to content

Dev script - Extract fatimage.yml logs to analyse packer build times #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 16, 2024

Conversation

bertiethorpe
Copy link
Member

@bertiethorpe bertiethorpe commented Sep 9, 2024

Python script for dev:
Extracts packer build ansible tasks from fatimage.yml logs to CSV.

TODO: Retrieve logs with GH CLI so we don't have to download logs manually. NOTE(scott): Decided this was more effort that it's work

extract fatimage logs and process ansible timings
@bertiethorpe
Copy link
Member Author

Checks cancelled because don't test changes

@bertiethorpe bertiethorpe requested a review from sd109 September 9, 2024 14:42
@bertiethorpe bertiethorpe self-assigned this Sep 9, 2024
@bertiethorpe bertiethorpe marked this pull request as ready for review September 10, 2024 10:11
@bertiethorpe bertiethorpe requested a review from a team as a code owner September 10, 2024 10:11
sjpb
sjpb previously requested changes Sep 13, 2024
@bertiethorpe bertiethorpe requested review from sd109 and sjpb September 16, 2024 08:57
Copy link
Member

@sd109 sd109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@sd109 sd109 dismissed sjpb’s stale review September 16, 2024 15:38

Changes addressed

@sd109 sd109 merged commit 8bfe946 into main Sep 16, 2024
2 checks passed
@sd109 sd109 deleted the dev/extract-fatimage-logs branch September 16, 2024 15:38
@sjpb
Copy link
Collaborator

sjpb commented Sep 17, 2024

@sd109 @bertiethorpe this still has a TODO in the first comment? If this isn't going to be done can you just rephrase this as a limitation please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants