Skip to content

Remove local DNS as a dependency for k3s #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Sep 19, 2024

I've tested this and terraform appears to behave properly, i.e. dependency tracking works.

Note using openstack_compute_instance_v2.control["control"].access_ip_v4 is not, in the general case OK:

access_ip_v4 - The first detected Fixed IPv4 address.

(source)

if the terraform is extended with another interface (which it often is) then this might not be right.

@wtripp180901 wtripp180901 marked this pull request as ready for review September 19, 2024 15:59
@wtripp180901 wtripp180901 requested a review from a team as a code owner September 19, 2024 15:59
Copy link
Contributor

@wtripp180901 wtripp180901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some changes to the ansible-init file so it works if the server isn't defined, should be good to merge

@wtripp180901 wtripp180901 merged commit 132e49e into feature/k3s-ansible-init Sep 20, 2024
1 check failed
@wtripp180901 wtripp180901 deleted the feat/k3s-no-etchosts branch September 20, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants