Skip to content

Fix adhoc/rebuild wait_for_connection race condition #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

bertiethorpe
Copy link
Member

When rebuilding nodes, a race condition can result in ssh connection being re-established before rebuild has begun.

Delay of 60s fixes this.

When rebuilding nodes, a race condition can result in ssh connection being re-established before rebuild has begun.

Delay of 60s fixes this.
@bertiethorpe bertiethorpe requested a review from a team as a code owner November 20, 2024 10:15
Copy link
Contributor

@wtripp180901 wtripp180901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bertiethorpe bertiethorpe merged commit f23be23 into main Nov 20, 2024
0 of 2 checks passed
@bertiethorpe bertiethorpe deleted the fix/adhoc-rebuild branch November 20, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants