Skip to content

Add list of additional package installs #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Dec 20, 2024
Merged

Add list of additional package installs #499

merged 18 commits into from
Dec 20, 2024

Conversation

wtripp180901
Copy link
Contributor

Packages list in appliances_default_extra_packages are now installed during build by default. Can optionally re-run install commands during site by setting appliances_packages_during_configure

@wtripp180901 wtripp180901 requested a review from a team as a code owner December 16, 2024 10:41
@wtripp180901
Copy link
Contributor Author

https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/12352678178

@wtripp180901
Copy link
Contributor Author

https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/12372330917

Base automatically changed from feat/pulp-builds to main December 17, 2024 15:20
sjpb
sjpb requested changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments on docs only, will need an image rebuild when rebasing onto main.

wtripp180901 and others added 2 commits December 19, 2024 11:41
@wtripp180901
Copy link
Contributor Author

https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/12412029407

@wtripp180901 wtripp180901 requested a review from sjpb December 19, 2024 13:29
sjpb
sjpb requested changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry ... variable name changes AND corresponding docs changes please!

@wtripp180901 wtripp180901 requested a review from sjpb December 19, 2024 14:56
sjpb
sjpb previously approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb changed the title Added list of additional package installs Add list of additional package installs Dec 19, 2024
bertiethorpe
bertiethorpe approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@bertiethorpe bertiethorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bertiethorpe bertiethorpe merged commit 8059d24 into main Dec 20, 2024
7 checks passed
@bertiethorpe bertiethorpe deleted the feat/extra-packages branch December 20, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertiethorpe bertiethorpe bertiethorpe approved these changes

@sjpb sjpb sjpb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wtripp180901 @sjpb @bertiethorpe