Skip to content

Fix Lustre deleting rdma packages and bump to v2.15.6 for RL9.5 support #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jan 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/extra.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,14 @@ on:
- 'environments/.stackhpc/terraform/cluster_image.auto.tfvars.json'
- 'ansible/roles/doca/**'
- 'ansible/roles/cuda/**'
- 'ansible/roles/lustre/**'
- '.github/workflows/extra.yml'
pull_request:
paths:
- 'environments/.stackhpc/terraform/cluster_image.auto.tfvars.json'
- 'ansible/roles/doca/**'
- 'ansible/roles/cuda/**'
- 'ansible/roles/lustre/**'
- '.github/workflows/extra.yml'

jobs:
Expand All @@ -29,11 +31,11 @@ jobs:
build:
- image_name: openhpc-extra-RL8
source_image_name_key: RL8 # key into environments/.stackhpc/terraform/cluster_image.auto.tfvars.json
inventory_groups: doca,cuda
inventory_groups: doca,cuda,lustre
volume_size: 30 # needed for cuda
- image_name: openhpc-extra-RL9
source_image_name_key: RL9
inventory_groups: doca,cuda
inventory_groups: doca,cuda,lustre
volume_size: 30 # needed for cuda
env:
ANSIBLE_FORCE_COLOR: True
Expand Down
8 changes: 0 additions & 8 deletions ansible/fatimage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -230,14 +230,6 @@
name: cloudalchemy.grafana
tasks_from: install.yml

- hosts: doca
become: yes
gather_facts: yes
tasks:
- name: Install NVIDIA DOCA
import_role:
name: doca

- name: Run post.yml hook
vars:
appliances_environment_root: "{{ lookup('env', 'APPLIANCES_ENVIRONMENT_ROOT') }}"
Expand Down
2 changes: 1 addition & 1 deletion ansible/roles/lustre/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Install and configure a Lustre client. This builds RPM packages from source.

## Role Variables

- `lustre_version`: Optional str. Version of lustre to build, default `2.15.5` which is the first version with EL9 support
- `lustre_version`: Optional str. Version of lustre to build, default `2.15.6` which is the first version with EL9.5 support
- `lustre_lnet_label`: Optional str. The "lnet label" part of the host's NID, e.g. `tcp0`. Only the `tcp` protocol type is currently supported. Default `tcp`.
- `lustre_mgs_nid`: Required str. The NID(s) for the MGS, e.g. `192.168.227.11@tcp1` (separate mutiple MGS NIDs using `:`).
- `lustre_mounts`: Required list. Define Lustre filesystems and mountpoints as a list of dicts with keys:
Expand Down
2 changes: 1 addition & 1 deletion ansible/roles/lustre/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
lustre_version: '2.15.5' # https://www.lustre.org/lustre-2-15-5-released/
lustre_version: '2.15.6' # https://www.lustre.org/lustre-2-15-6-released/
lustre_lnet_label: tcp
#lustre_mgs_nid:
lustre_mounts: []
Expand Down
31 changes: 5 additions & 26 deletions ansible/roles/lustre/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,30 +41,9 @@
ansible.builtin.dnf:
name: "{{ _lustre_find_rpms.files | map(attribute='path')}}"
disable_gpg_check: yes

- block:
- name: Remove lustre build prerequisites
# NB Only remove ones this role installed which weren't upgrades
ansible.builtin.dnf:
name: "{{ _new_pkgs }}"
state: absent
vars:
_installed_pkgs: |
{{
_lustre_dnf_build_packages.results |
select('match', 'Installed:') |
map('regex_replace', '^Installed: (.+?)-[0-9].*$', '\1')
}}
_removed_pkgs: |
{{
_lustre_dnf_build_packages.results |
select('match', 'Removed:') |
map('regex_replace', '^Removed: (.+?)-[0-9].*$', '\1')
}}
_new_pkgs: "{{ _installed_pkgs | difference(_removed_pkgs) }}"

- name: Delete lustre build dir
file:
path: "{{ lustre_build_dir }}"
state: absent

- name: Delete lustre build dir
file:
path: "{{ lustre_build_dir }}"
state: absent
when: lustre_build_cleanup | bool